From: Daniel Veillard (Daniel.Veillard@w3.org)
Date: Wed Oct 11 2000 - 07:24:53 EDT
On Fri, Oct 06, 2000 at 12:20:10PM -0700, Wayne Davison wrote:
> On Fri, 6 Oct 2000, Daniel Veillard wrote:
> > Please check it out if you're using Windows or XPath, i probably
> > won't be able to make a real release before next Wed, and won't
> > answer mail in the meantime. Send patches !
>
> Here's what I found wrong and (in most cases) fixed:
>
> + Several .c files were including "xmlversion.h" rather than
> <libxml/xmlversion.h>.
I had alredy fixed this ;-)
> + There is an undefined call to xmlXPathFreeLocationSet() in xpath.c.
> This might be because xpointer.[ch] are not in the tar file, but I
> just #if-0-ed the call out of the source for now.
same
> + The Makefile.in was still trying to create libxml, even with the
> include/libxml dir existing. I changed this so that the Makefile
> looks for include/libxml, and creates "include" as a dir and puts
> the libxml symlink into the include dir if it is missing.
Makefile.in is generated, i think I fixed the configure.in and Makefile.am
> + Changed configure.in to create "include" as a directory with the
> "libxml" symlink inside it. It looks like the code that was supposed
> to create these items inside the build dir (when it differs from the
> src dir) was broken, and I think I fixed it (though I didn't try to
> configure things from an separate build dir).
Yeah and "make distchek" was still broken ... Changed this, this is fixed
I think.
> + Removed include/libxml/config.h.in, as it is not needed.
done
> defines in xmlversion.h, so I removed them. This makes the file
> have no @...@ expansions, so I just renamed the *.in version to be
> the .h version and removed it from the configure.in file.
done
> + The win32include.h file should not be in the include/libxml dir
> (since it doesn't get installed). I moved it into the include dir.
done
> + Added the file win32/Makefile.mingw, which is a simplified Makefile
> that builds the library, a DLL, and the tools using the mingw gcc
> compiler.
done
> + I tweaked the win32/README.MSDev to remove all mention of copying
> .h files and commenting out the LIBXML_VERSION* defines, added a
> comment that the diff is out of date now, and mention the build
> instructions for using the "mingw" gcc compiler.
done
> + I changed the include/libxml/libxmlversion.h file that was included
> in the tar file so that LIBXML_ICONV_ENABLED is not defined. I like
> the fact that this file is there, as it means that MSWin developers
> can have an easier file to tweak (and it works without change after my
> fix if you're using the mingw compiler), and it gets replaced by the
> normal configuration process for other folks.
Hum, I probably skipped this one
> A patch is appended. To summarize what to do after the patch:
>
> # After running "patch -p0 <wayne.patch"
> rm include/libxml/config.h.in
> mv include/libxml/win32config.h.in include/win32config.h
>
> TODO:
>
> + Remove #if-0 from xpath.c and solve build problem.
Done
> + Figure out why example/Makefile.in doesn't exist (this is a
> long-standing problem with libxml, but it just seems to cause
> configure to complain).
Long pending one ... Seems I'm getting acquainted enough with automake
now that I could chase this one successfully ... Still todo
Daniel
-- Daniel.Veillard@w3.org | W3C, INRIA Rhone-Alpes | Today's Bookmarks : Tel : +33 476 615 257 | 655, avenue de l'Europe | Linux XML libxml WWW Fax : +33 476 615 207 | 38330 Montbonnot FRANCE | Gnome rpm2html rpmfind http://www.w3.org/People/all#veillard%40w3.org | RPM badminton Kaffe ---- Message from the list xml@rpmfind.net Archived at : http://xmlsoft.org/messages/ to unsubscribe: echo "unsubscribe xml" | mail majordomo@rpmfind.net
This archive was generated by hypermail 2b29 : Wed Oct 11 2000 - 09:43:41 EDT