is this a bug?

Date view Thread view Subject view Author view

From: Archie Cobbs (archie@whistle.com)
Date: Wed Feb 17 1999 - 20:34:47 EST

This assertion failure is not going away, so I'm starting to try
and learn more about jthreads, garbage collection, etc.

I noticed a potential bug in signal.c and was curious if this
is minor or major. The bug is that newact.sa_mask is not getting
initialized. Not sure if this would cause any weird behavior though.

Index: signal.c
===================================================================
RCS file: /cvs/mod/net/kaffe/kaffe/kaffevm/systems/unix-jthreads/Attic/signal.c,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 signal.c
--- signal.c 1999/02/17 01:26:28 1.1.2.1
+++ signal.c 1999/02/18 01:34:50
@@ -109,13 +109,13 @@
         struct sigaction newact;
 
         newact.sa_handler = (SIG_T)handler;
+ sigemptyset(&newact.sa_mask);
         
         /*
          * Define sa_mask to include the signals to block when
          * running handler.
          */
         if (isAsync) {
- sigemptyset(&newact.sa_mask);
                 sigaddset(&newact.sa_mask, SIGIO);
                 sigaddset(&newact.sa_mask, SIGALRM);
                 sigaddset(&newact.sa_mask, SIGCHLD);

Thanks,
-Archie

___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com

Date view Thread view Subject view Author view

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 19:58:10 EDT