Dec 7 commit & Thread safe fields usage (fwd)

Date view Thread view Subject view Author view

From: Godmar Back (gback@cs.utah.edu)
Date: Tue Dec 08 1998 - 11:31:46 EST

 Okay, let's do the important ones.

Most of them are awt specific, so I'll be of little help.

I can fix the awt/X warnings.

Minus the volatiles, this is what's left then:

It think the "should not use" should read as "shouldn't it use" (?)

> -----------------------------------------
>
> java.awt.Default
> already have RgbRequests reintroduced by java.awt.RequestRgb.
>
> java.awt.EventDispatchThread
> now use WMEvent.getEvent() in place of new WMEvent(), is the comment:
> "no need to loop, nobody else knows 'e'" again true ?
>
> Comments for Thread safe/unsafe fields usage:
> ---------------------------------------------
>
> java.awt.EventDispatchThread
> run(Window), show(Window): both use Thread.currentThread() !=
> Toolkit.eventThread(), should not use Toolkit.isWrongThread() ?
>
> java.awt.EventQueue
> postEvent(), repain(): use Toolkit.isBlocking && (Thread.currentThread()
> != Toolkit.eventThread), should not use Toolkit.isWrongThread() ?
>
> java.awt.Window
> removeNotify(), line 227, while (nativeData == null) should be
> while (nativeData != null)
> addNotify(), removeNotify(): use Toolkit.isDispatchEclusive &&
> (Thread.currentThread() != Toolkit.eventThread), should not use
> Toolkit.isWrongThread() ?
>

Plus, why the hell does CLTest fail now with that "1 warning"
thing? Should we just diff pizza's stderr against "1 warning"
for this particular test?

        - Godmar

Date view Thread view Subject view Author view

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 19:57:08 EDT