Re: problem with patch

Date view Thread view Subject view Author view

From: Archie Cobbs (archie@whistle.com)
Date: Fri Oct 16 1998 - 14:22:36 EDT


Godmar Back writes:
> > Archie Cobbs writes:
> > > The patch below (which was recently committed after 1.0b2) causes
> > > my SableCC parser compilation to strangely fail. I fear that the
> > > patch is not correct somehow, but I have no idea how (haven't
> > > had time to investigate the problem yet).
> >
> > Ah, found the problem... it was simple. The patch was only
> > patching the #ifdef INTERPRETER version of soft_multianewarray();
> > the #ifdef TRANSLATOR version of the same patch was not included.
> > Fixed now.
> >
>
> Now how is it possible then that unapplying the patch fixed your
> program?

Good question :-)

Because there were two individual patches that I was applying/unapplying
together (because they were committed together).. and only one of them
was within the #ifdef TRANSLATOR.

In other words, I was only getting half of the patches. If I was
running in TRANSLATOR mode I wouldn't ever have noticed.

-Archie

___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com


Date view Thread view Subject view Author view

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 19:57:00 EDT