Re: kaffe 1.0b2?

Date view Thread view Subject view Author view

From: Archie Cobbs (archie@whistle.com)
Date: Wed Sep 02 1998 - 14:29:12 EDT


Tim Wilkinson writes:
> Most defainately - we've about to merge in some new graphics code (handling
> GIFs and PNG amongst other things) from the Custom tree where we've been
> stabilising it. Once this I think we should release the next beta. Ideally
> this would include Swing support but I don't think that'll make it in (don't
> ask about Swing - it's all too horrid - Sun should be shot for what they've
> done).

Cool...

Hey Tim, while I've got you, I'd like to ask your advice in removing
the remaining compiler warnings.. these all come from jit.def (included
by funcs.c), for example:

    gcc -g -O2 -Wall -Wstrict-prototypes -I. -I. -I./../../config -I../../config -I../../include -I./../../include -I../../libraries/clib -DTRANSLATOR -I./jit -DKVER=\"1.00\" -c -fPIC ./jit/funcs.c -o funcs.o
    jit.def: In function `fspill_Rxx':
    In file included from ./jit/funcs.c:44:
    jit.def:256: warning: unused variable `r'
    jit.def: In function `fspilll_Rxx':
    jit.def:268: warning: unused variable `r'
    jit.def: In function `freload_Rxx':
    jit.def:292: warning: unused variable `w'

Here's function fspill_Rxx:

    define_insn(spill_float, fspill_Rxx)
    {
            int r = sreg_float(0);
            int o = const_int(1);

            OUT = 0xD9;
            OUT = 0x98|REG_ebp;
            LOUT = o;

            debug(("fstp %d(ebp)\n", o));
    }

Now clearly 'r' is unused, but 'sreg_float(0)' may have side effects.
So which of these options should be taken:

 (a) Do nothing
 (b) Remove the entire line 'int r = sreg_float(0);'
 (c) Change the line 'int r = sreg_float(0);' to just be 'sreg_float(0);'

Thanks,
-Archie

___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com


Date view Thread view Subject view Author view

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 19:56:54 EDT