Re: -Wall fixes

Date view Thread view Subject view Author view

From: Archie Cobbs (archie@whistle.com)
Date: Thu Aug 27 1998 - 15:26:13 EDT


Godmar Back writes:
> I checked in a bunch of -Wall fixes I got from Archie.
> It's not perfect yet, so see how you like it.
>
> He also sent the fixes below for the awt/X directory.
> Peter, do you want me to check them in? Or maybe Archie
> can do it himself?

I'd be happy to do it myself, as soon as I get 'keys' to
the repository.

I also have some more fixes pending for -Wstrict-prototypes.
All but one are trivial. The last is not trivial, but I think
easily solved.

The issue is these declarations from exception.h:

  extern void nullException();
  extern void floatingException();

These cause a warning because they are old-style prototypes.
Here's how they are defined in exception.c:

  void
  nullException(EXCEPTIONPROTO)
  {
   ...
  }

  void
  floatingException(EXCEPTIONPROTO)
  {
   ...
  }

The problem is a combination of these factors:

  - If -DTRANSLATOR, EXCEPTIONPROTO is defined in jit-md.h in a
    per-operating manner.

  - If -DINTERPRETER, EXCEPTIONPROTO is not defined, except as
    "int sig" within exception.c.

  - When building libnative, neither -DTRANSLATOR nor -DINTERPRETER
    is defined, so we don't know which prototype to use in exception.h

So it's not possible to just add a prototype to the exception.h
declaration.

My proposed solution:

  Since initExceptions() is the only function outside of exception.c
  that references, nullException() and floatingException(), we move
  initExceptions() into exception.c and make nullException() and
  floatingException() static.

-Archie

___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com


Date view Thread view Subject view Author view

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 19:56:54 EDT